internal: Align MIR ProjectionElem more with rustc's version and simplify it#22510
Merged
Merged
Conversation
Member
flodiebold
commented
Jun 1, 2026
flodiebold
commented
- Instead of three Field variants, we now have just one that takes just a field index, like rustc (except rustc also tracks the type).
- Enum variant downcasting in patterns is handled with the Downcast projection like in rustc; previously it happened implicitly through the FieldId which knew its variant
- Introduce PlaceTy helper for this variant downcasting
- Align projection_ty code mostly with rustc
- Remove unused OpaqueCast variant for now
…ant ID / tuple ID needed) bring back env for projection_ty cleanups
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Jun 2, 2026
flodiebold
force-pushed
the
mir-salsa-projections
branch
from
f10f7ae to
d8155bc
Compare
flodiebold
force-pushed
the
mir-salsa-projections
branch
from
d8155bc to
71a9c63
Compare
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.